Style hr transition in base-navigation-and-footer #15194
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15194 +/- ##
=======================================
Coverage 77.88% 77.88%
=======================================
Files 162 163 +1
Lines 8473 8480 +7
=======================================
+ Hits 6599 6605 +6
- Misses 1874 1875 +1 ☔ View full report in Codecov by Sentry. |
| @import 'transition'; | ||
| @import 'components/footer-refresh'; |
There was a problem hiding this comment.
Hmh while working this produces not so nice results for some pages that end with colour shapes, like:
(barely visible, but it's there…)
or better:
and
or
Hiding the hr for now with low specificity .m24-c-transition * { display: none; } (that's only effective until the proper declaration is loaded) looks perhaps better — but that doesn't solve the issue once 2024 styles are turned on site-wide — when that divider gets styled globally and places with somewhat rectangular blocks ending the pages will display like this anyway…
|
Hmm, I'm curious on @stephaniehobson's take on this solution she suggested. It seems like this pixelated footer is going to look very awkward with some pages (such as the |
stephaniehobson
added
Needs Review
|
This is no longer relevant as the new direction was set in #15410 |
One-line summary
In #15125 the hr divider was moved from refreshed pages to the refreshed footer, applied to all pre-existing pages — thus needs the styling applied independently with the footer, too.
Significant changes and points to review
Issue / Bugzilla link
Fixes #15152 and #15159
Testing
http://localhost:8000/en-CA/impact/
http://localhost:8000/en-CA/advertising/
http://localhost:8000/en-GB/firefox/developer/
http://localhost:8000/en-GB/firefox/nightly/firstrun/
http://localhost:8000/en-US/careers/